TEL-4972: create switch_core_session_get_channel_unsafe in order to avoid crash when no channel #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…void crash when no channel
|
The reason why they added the assert is that there shouldn't be a case where a session doesn't have a channel. When you create a session, it will always create a channel. You won't be able to destroy the channel without killing the session first. |
@dev-ryanc assert should be disabled on production build (actually Stefan needs it to be disabled on debug build too and I can understand this, so this PR makes sense, only the content should be changed slightly) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the switch_core_session_get_channel has an
assertthat leads to a crash when the channel is not ready or already hang up which happens a lot with Push Notification calls.see mod_telnyx_rtc PR #49